Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions: drush to 8.3.1, node to 12.x in web container, fixes #1907 #1909

Merged
merged 3 commits into from Nov 4, 2019

Conversation

heddn
Copy link
Collaborator

@heddn heddn commented Oct 28, 2019

The Problem/Issue/Bug:

A new version of drush 8 was released (8.3.0 current => 8.3.1 proposed new version).
Also bumps nodejs version to 12.x, replacing #1908

How this PR Solves The Problem:

It bumps the version.

Manual Testing Instructions:

Automated Testing Overview:

Related Issue Link(s):

Release/Deployment notes:

Bump version of Drush in containter to 8.3.1
@rfay
Copy link
Member

rfay commented Oct 28, 2019

Thanks so much!

@rfay rfay changed the title Bump version of Drush in containter to 8.3.1 Bump version of drush/node in web container Nov 4, 2019
@rfay
Copy link
Member

rfay commented Nov 4, 2019

I bumped the version.go and pushed the container with this. Also brought in #1908's commit, and will close that one, because if we're updating the container we might as well do it once.

If you're good with this it can come in as soon as tests are green.

@rfay rfay changed the title Bump version of drush/node in web container Bump version of drush/node in web container, fixes #1907 Nov 4, 2019
@rfay rfay changed the title Bump version of drush/node in web container, fixes #1907 Bump version drush to 8.3.1, node to 12.x in web container, fixes #1907 Nov 4, 2019
@rfay rfay changed the title Bump version drush to 8.3.1, node to 12.x in web container, fixes #1907 Bump versions: drush to 8.3.1, node to 12.x in web container, fixes #1907 Nov 4, 2019
@rfay rfay merged commit be95d88 into ddev:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants