Pantheon should not authenticate when just initing app, fixes #1905 #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
force-pushed
the
20191102_bad_pantheon_check
branch
from
4b5c675
to
f47e396
Compare
rfay
force-pushed
the
20191102_bad_pantheon_check
branch
from
e2c9fc7
to
e17de0f
Compare
rfay
force-pushed
the
20191102_bad_pantheon_check
branch
from
e17de0f
to
2ba9797
Compare
This was referenced Nov 20, 2019
Closed
rfay
added a commit
to rfay/ddev
that referenced
this pull request
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
An app.Init() is done for most operations.. but if it's a pantheon provider, that means it was phoning home to verify the name of the project. Shouldn't do that. #1905.
How this PR Solves The Problem:
Stop validating on app.Init()
Manual Testing Instructions:
Automated Testing Overview:
Related Issue Link(s):
Release/Deployment notes: