Skip tools installation in chocolatey mode (Windows installer) #1937
Conversation
Skips mkcert and nssm from installation in silent mode
rfay
changed the title
|
It seems that this makes the assumption "silent mode" == "choco install". That might not be correct. I hate to add too much complexity. Wonder if there's a way to detect choco install. It's always possible that we should have a separate chocolatey installer :( |
This patch forces the installtion of sudo as DDEV can normaly not run correctly and full function without it. The license page is now showed before the component selection because it is not optional as before.
You're absolutely right but I don't think one will install DDEV in silent mode. So we can assume silent mode = choco install |
There is a way to get parameters and options from the command line. So I will add a choco parameter to the next commit... |
|
We have now a special Choco mode (see commit) enabled with the parameters /S /C |
This patch adds a special Chocolatey mode which will prevent the installation of dependencies installed by Chocolatey.
gilbertsoft
force-pushed
the
task-ignore-tools
branch
from
503093b
to
efd4aff
Compare
gilbertsoft
changed the title
|
I see this was already done here. Not sure why I couldn't see it before. |
That's already done with the related commit. Currently I don't know why the test fails. Did a restart two times... |
…1937) * Skip tools installation in silent mode Skips mkcert and nssm from installation in silent mode * Force installation of sudo This patch forces the installtion of sudo as DDEV can normaly not run correctly and full function without it. The license page is now showed before the component selection because it is not optional as before. * Add Chocolatey mode This patch adds a special Chocolatey mode which will prevent the installation of dependencies installed by Chocolatey.
The Problem/Issue/Bug:
Installing DDEV with Chocolaty should prefer the tools installed as dependencies instead of the ones bundled with the DDEV Windows installer
How this PR Solves The Problem:
Skips mkcert and nssm from installation in the new choco mode /S /C
Manual Testing Instructions:
Run the installer with options /S /C and check the tools are not installed. If they are already present they will be kept and prefered by DDEV
Automated Testing Overview:
Related Issue Link(s):
#1935
Release/Deployment notes: