Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR: Improve docs and docker-compose.solr.yaml #1943

Merged
merged 3 commits into from Nov 14, 2019
Merged

Conversation

rfay
Copy link
Member

@rfay rfay commented Nov 13, 2019

The Problem/Issue/Bug:

There's always been a lot of magic involved with our docker-compose.solr.yaml and instructions. This PR attempts to improve the docs and the docker-compose.solr.yaml so people can understand what's important and how to change it.

How this PR Solves The Problem:

Manual Testing Instructions:

  • Work through it all from scratch.

Automated Testing Overview:

Related Issue Link(s):

Release/Deployment notes:

@rfay
Copy link
Member Author

rfay commented Nov 14, 2019

I'm going to go ahead and pull this, because I'm trying to write it up in a blog post, and the links won't be valid unless I pull it. I still very much appreciate reviews or comments (or issues or PRs) here, and will follow up as needed.

@rfay rfay merged commit 50b7ff8 into ddev:master Nov 14, 2019
@rfay rfay deleted the 20191112_solr branch November 14, 2019 17:34
rfay added a commit to rfay/ddev that referenced this pull request Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant