[TASK] Remove empty trailing lines from PHP files and templates #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems I messed up my master. But no issue for this PR. Will clean it afterwards... |
This patch removes empty trailing lines from PHP files and configuration templates to comply with PSR-12 which defines the following on file endings: All PHP files MUST end with a non-blank line, terminated with a single LF. See https://www.php-fig.org/psr/psr-12/#22-files
gilbertsoft
force-pushed
the
task/comply-psr-12
branch
from
3395429
to
48c7c95
Compare
|
It's rebased now |
gilbertsoft
commented
Dec 19, 2019
| 'displayErrors' => 1 | ||
| ] | ||
| 'displayErrors' => 1, | ||
| ], |
There was a problem hiding this comment.
btw this trailing commas are recommended because it's less error prone if you add something new afterwards
There was a problem hiding this comment.
Always. But of course they ruin js/json :)
rfay
pushed a commit
to rfay/ddev
that referenced
this pull request
Jan 15, 2020
…#2007) This patch removes empty trailing lines from PHP files and configuration templates to comply with PSR-12 which defines the following on file endings: All PHP files MUST end with a non-blank line, terminated with a single LF. See https://www.php-fig.org/psr/psr-12/#22-files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes empty trailing lines from PHP files and configuration
templates to comply with PSR-12 which defines the following on file endings:
All PHP files MUST end with a non-blank line, terminated with a single LF.
See https://www.php-fig.org/psr/psr-12/#22-files