Provide explicit Drupal9 nginx configuration #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
The drupal9 configuration in ddev-webserver was left out in v1.14; as a result, the default configuration was in use. It seemed to work for everything, but it needs its own configuration.
The explicit test in the container was also left out, and that's how this was discovered, when working on drud/ddev-images#3
How this PR Solves The Problem:
Add the Drupal9 explicit nginx config (just a copy of drupal8)
Manual Testing Instructions:
Automated Testing Overview:
Related Issue Link(s):
Release/Deployment notes:
This probably requires a release v1.14.2