Improve error message when ddev auth pantheon has not been run, fixes #2241 #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
#2241 points out the common problem that if people haven't done a
ddev auth pantheonthen they get a cryptic message onddev config pantheonandddev pullthat doesn't say "hey, do addev auth pantheon"How this PR Solves The Problem:
Improves that message to "unable to get Pantheon environments for project %s - Have you authenticated with
ddev auth pantheon? Does the ddev project name match the pantheon project name?"Manual Testing Instructions:
Start a pantheon project without doing a
ddev auth pantheon. If you need to kill off the existing authentication,ddev exec rm -r /mnt/ddev-global-cache/terminus/cache/*ddev config pantheonand see the error message.ddev auth pantheonand then tryddev config pantheonagain to see it work.Automated Testing Overview:
Related Issue Link(s):
Release/Deployment notes: