Adds ddev-live as a default custom command #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
requested changes
May 29, 2020
There was a problem hiding this comment.
This still needs a make packr2 to get it included, I can take care of that.
I do suspect this should be ddev-live.example for now, until there are more users that would want it. It would be nice if we could figure out how to include it only if provider type were ddev-live. (Hoping to be able to add commands per project type in a coming release, commands per provider type would be a great addition)
|
One request @unn - Please don't push directly into the drud/ddev repository. It makes a mess. Use your unn/ddev fork and use the forked-pr workflow, thanks. |
rfay
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
Now that the ddev-live tool is in the web container we should ship a default custom command for
liveHow this PR Solves The Problem:
livecommand resulting in commandsddev liveManual Testing Instructions:
Automated Testing Overview:
Related Issue Link(s):
Release/Deployment notes: