Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put zsh completions in correct place in homebrew bottle, fixes #2317 #2326

Merged
merged 2 commits into from Jun 23, 2020

Conversation

rfay
Copy link
Member

@rfay rfay commented Jun 23, 2020

The Problem/Issue/Bug:

#2317: Zsh and fish completions were not being placed properly in the homebrew bottle.

How this PR Solves The Problem:

Put them in the correct place.

Manual Testing Instructions:

  • brew uninstall ddev
  • Verify that the zsh completions are gone
  • brew install ddev
  • Verify that zsh and fish completions have been properly added to /usr/local/share/zsh/site-functions and that they work

It should say

zsh functions have been installed to:
  /usr/local/share/zsh/site-functions

Automated Testing Overview:

Related Issue Link(s):

OP #2317

Release/Deployment notes:

This needs to be tested after next alpha release

@rfay rfay merged commit 7c866fa into ddev:master Jun 23, 2020
@rfay rfay deleted the 20200623_zsh_autocomplete branch June 23, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant