Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Improvements and typo fixes #2396

Merged
merged 4 commits into from Jul 28, 2020
Merged

[DOCS] Improvements and typo fixes #2396

merged 4 commits into from Jul 28, 2020

Conversation

crydotsnake
Copy link
Contributor

No description provided.

@rfay rfay changed the title [DOCS] Improvments and typo fixes [DOCS] Improvements and typo fixes Jul 21, 2020
@crydotsnake
Copy link
Contributor Author

Is there anything i have to change?.

@rfay
Copy link
Member

rfay commented Jul 27, 2020

Yes, this came in quite late and conflicts, so you'll need to rebase and fix the conflicts.

A lot of the changes you suggest are more your opinion than definite needs, so I'll take another look at it in the v1.16 process.

I've been ignoring v1.16-targeted PRs until v1.15 is fully sorted out, so that's why I haven't done anything here.

@rfay
Copy link
Member

rfay commented Jul 28, 2020

I rebased this and reviewed it, made a number of trivial changes. PhpStorm really is PhpStorm, please ask before deciding usage in the future.

@rfay rfay reopened this Jul 28, 2020
@rfay
Copy link
Member

rfay commented Jul 28, 2020

I pushed the results in here.

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the careful work. I especially liked having the language type on the ``` blocks.

Please do check carefully for official name of products before changing them. PhpStorm is not PHPStorm.

Please ask the maintainer about usage preferences before making wholesale changes to docs - they may have preferences. "DDEV" over "ddev" is not that important to me. But it will do. But it will save you time and the maintainer time when you make contributions if you ask first on something like this.

@rfay rfay merged commit 1e6ec33 into ddev:master Jul 28, 2020
@crydotsnake
Copy link
Contributor Author

Okay. Thanks a lot Randy!. And sorry!. Next time, i will make the PR better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants