Gitignore the .homeadditions completely, fixes #2374 #2400
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
#2374 describes the issue when something is added to ~/.ddev/homeadditions and then you do a
ddev start
.The resulting homeadditions item gets copied into the project at .ddev/.homeadditions and then it is not properly gitignored.
How this PR Solves The Problem:
Add .homeadditions to the gitignore.
Manual Testing Instructions:
git status
is clean)ddev start
git status
should still be clean.Automated Testing Overview:
Added this scenario to TestConfigGitIgnore() and also added global commands the same way.
Related Issue Link(s):
#2374
Release/Deployment notes: