Docs: More failsafe on WSLENV having colon [skip ci][ci skip] #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilbertsoft
requested changes
Jul 22, 2020
| @@ -63,7 +63,7 @@ We'll walk through these in more detail. You may prefer other techniques of inst | |||
| 2. **Chocolatey:** We recommend using Chocolatey for [Chocolatey](https://chocolatey.org/install) installing required Windows apps like mkcert. In an administrative PowerShell, `Set-ExecutionPolicy Bypass -Scope Process -Force; [System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072; iex ((New-Object System.Net.WebClient).DownloadString('https://chocolatey.org/install.ps1'))` | |||
| 3. In an administrative PowerShell: `choco install -y mkcert` | |||
| 4. In administrative PowerShell, run `mkcert -install` and answer the prompt allowing the installation of the Certificate Authority. | |||
| 5. In administrative PowerShell, run the command `setx CAROOT "$(mkcert -CAROOT)"; If ($Env:WSLENV -notlike "*CAROOT*") { setx WSLENV "CAROOT/up:$Env:WSLENV" }`. This will set WSL2 to use the Certificate Authority installed on the Windows side. | |||
| 5. In administrative PowerShell, run the command `setx CAROOT "$(mkcert -CAROOT)"; If ($Env:WSLENV -notlike "*CAROOT/up:*") { setx WSLENV "CAROOT/up:$Env:WSLENV" }`. This will set WSL2 to use the Certificate Authority installed on the Windows side. | |||
There was a problem hiding this comment.
Suggested change
| 5. In administrative PowerShell, run the command `setx CAROOT "$(mkcert -CAROOT)"; If ($Env:WSLENV -notlike "*CAROOT/up:*") { setx WSLENV "CAROOT/up:$Env:WSLENV" }`. This will set WSL2 to use the Certificate Authority installed on the Windows side. | |
| 5. In administrative PowerShell, run the command `setx CAROOT "$(mkcert -CAROOT)"; If ($Env:WSLENV -notlike "*CAROOT/up:*") { setx WSLENV ("CAROOT/up:" + ($Env:WSLENV -replace '(.*)CAROOT[^:;]*[:;](.*)', '$1$2').Trim(':')) }`. This will set WSL2 to use the Certificate Authority installed on the Windows side. |
There was a problem hiding this comment.
Here we go, this new PS script should now also fix the errors from the first version with using ; instead of : as separator. It also fixes wrong options if a user has set it before.
There was a problem hiding this comment.
I don't object to the trim, but WSENV works fine without it. Also doubled CAROOT/up:CAROOT/up: works fine.
I really appreciate you adding this, but I think it's simpler as is. I think well-tested version of this will be OK in your script, but I'm going to pass on it here.
There was a problem hiding this comment.
The trim is to ensure we don't have a separator at the begin and end which could lead then to two separators, it's not really important but produces a cleaner variable value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
People have had trouble with ";" in the WSLENV environment variable. The result is not being able to get a trusted connection in chrome.
How this PR Solves The Problem:
Make sure that the WSLENV variable gets set to a usable value, even if it was previously set wrong.
Manual Testing Instructions:
Automated Testing Overview:
Related Issue Link(s):
Release/Deployment notes: