Make PHP_IDE_CONFIG work for both command-line and web debugging #2427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for fixing this promptly. |
|
Thanks! Note that you should use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
Unfortunately version v1.15.2 made Xdebug with PHPStorm work fine for people using it for web debugging, but broke it for command-line debugging. See #2424
This revision works with both command-line and web debugging.
How this PR Solves The Problem:
Make sure that PHP_IDE_CONFIG does not get loaded by php-fpm (which breaks web debugging) but does get loaded by
ddev ssh(using /etc/bash.bashrc)Manual Testing Instructions:
Try debugging with PHPStorm both with a web setup and a command-line setup.
Automated Testing Overview:
Related Issue Link(s):
Release/Deployment notes: