Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDEV-Live needs to delete its backups after pulling to avoid quota trouble #2428

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

rfay
Copy link
Member

@rfay rfay commented Jul 29, 2020

The Problem/Issue/Bug:

  • DDEV-Live recently implemented quotas, including quotas on backups of db and files
  • ddev-live-client was updated to v0.6.0 in v1.15.2+, and its syntax for deleting database backups has changed.
  • The test user that runs tests (and perhaps people who use backups) could easily run out of quota on backups because ddev pull doesn't clean them up.

How this PR Solves The Problem:

  • Make sure both files and db backups are deleted after we pull them.
  • Adjust code to the new ddev-live delete backup syntax

Manual Testing Instructions:

Just review ddev-live list backups or ddev live list backups after tests have run. There should be nothing there.

Automated Testing Overview:

Related Issue Link(s):

Release/Deployment notes:

@rfay rfay merged commit babae73 into ddev:master Jul 29, 2020
@rfay rfay deleted the 20200729_ddev_live_delete_backups branch July 29, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant