Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Atom XDebug Instructions #2498

Merged
merged 1 commit into from Sep 16, 2020
Merged

Conversation

WidgetsBurritos
Copy link
Contributor

@WidgetsBurritos WidgetsBurritos commented Sep 9, 2020

The Problem/Issue/Bug:

The php-debug package requires atom-ide-ui, but atom-ide-ui has it’s own debugger system which isn’t compatible with php-debug. So you essentially have to disable the debugger that comes with atom-ide-ui to use the php-debug debugger. After doing that everything works.

How this PR Solves The Problem:

It updates the XDebug + Atom documentation to provide instructions on doing this

Manual Testing Instructions:

Step through setup instructions on Atom and ensure Xdebug works

Automated Testing Overview:

Documentation change only, so no tests.

Related Issue Link(s):

gwomacks/php-debug#310 (comment)

Release/Deployment notes:

The atom-ide-ui dependency adds a few features to Atom, so it might slightly change the user experience, but overall it should be pretty seamless.

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2020

CLA assistant check
All committers have signed the CLA.

@rfay rfay merged commit bdfb162 into ddev:master Sep 16, 2020
@rfay
Copy link
Member

rfay commented Sep 16, 2020

Thanks for this @WidgetsBurritos !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants