Use standard Drupal/Backdrop default.settings.php as settings.php, fixes #1097 #2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
ddev has always provided a very minimal settings.php if none existed, which meant that some standard settings (and some hints to the user) were omitted.
How this PR Solves The Problem:
Each settings.php file for drupal6/7/8/9/backdrop is now based almost entirely on default.settings.php. The only thing that's added is the include of the settings.ddev.php.
Manual Testing Instructions:
rm sites/default/settings*.php && ddev startfor drupal6/7/8/9/backdrop. Verify that the settings.php file gets created, is based on default.settings.php, and the site is functional.Automated Testing Overview:
I think the existing tests are adequate for this.
Related Issue Link(s):
Release/Deployment notes: