Improve router-compose and ssh-auth-compose handling, fixes #1779, fixes #2476 #2505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
ddev stop
orddev restart
when you've never done addev start
to create the router-compose.yaml causes a fatal error (Unable to find .ddev/router-compose.yaml when restarting ddev when it has never been started #1779)How this PR Solves The Problem:
Manual Testing Instructions:
ddev poweroff && rm ~/.ddev/.ddev-router-compose* && ddev stop
. It should work fine.ddev poweroff
the expected stuff is used (docker exec ddev-router bash -c 'echo $ANSWER'
should get "42", as shoulddocker exec ddev-ssh-agent bash -c 'echo $ANSWER'
docker volume rm ddev-router-letsencrypt
- failure is OK. Thenddev start
and verify that no letsencrypt volume is created.Automated Testing Overview:
Related Issue Link(s):
Release/Deployment notes:
This changes the names of the router-compose and ssh-auth-compose files to hidden files, .router-compose.yaml, .router-compose-full.yaml, .ssh-auth-compose.yaml, .ssh-auth-compose-full.yaml