Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove php7.2 config override for typo3 and drupal7 #2612

Merged
merged 3 commits into from
Nov 7, 2020

Conversation

rfay
Copy link
Member

@rfay rfay commented Nov 6, 2020

The Problem/Issue/Bug:

Both TYPO3 and Drupal7 had configOverrideActions that set the PHP version to 7.2, and neither requires it.

In a recent TYPO3 test (with ddev v1.16.0-rc1), with latest deb.sury.org build PHP 7.2.34-8+020201103.52+debian101.gbpafa084 failed, even though 7.2.34-4 had worked fine.

An exception occurred while executing 'DELETE tags2, cache1 FROM cf_cache_pages_tags AS tags1 JOIN cf_cache_pages_tags AS tags2 ON tags1.identifier = tags2.identifier JOIN cf_cache_pages AS cache1 ON tags1.identifier = cache1.identifier WHERE tags1.tag = 'redirects'': Malformed communication packet

How this PR Solves The Problem:

  • Remove the php7.2 setting for Drupal7 and TYPO3. Both should work fine with the default php7.3. This seems to make more sense than chasing an obscure "malformed communication packet" issue in an obsolete PHP version.

Manual Testing Instructions:

Automated testing should be fine, but I recreated it manually as well.

Automated Testing Overview:

Related Issue Link(s):

Release/Deployment notes:

@rfay rfay merged commit 8e87bd3 into ddev:master Nov 7, 2020
@rfay rfay deleted the 20201106_typo3_php7.3 branch November 7, 2020 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant