Make install_ddev.sh work with v1.16.0-rc1 and hopefully future versions #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci][ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
install_ddev.sh is broken when trying to download ddev v1.16.0-rc1.
How this PR Solves The Problem:
Improve the version_compare (see gist so it does the right thing.
Output useful information when a curl fails
Manual Testing Instructions:
./install_ddev.sh v1.16.0-rc1./install_ddev.sh v1.15.3./install_ddev.sh v1.16.0-rc2and view error messageAutomated Testing Overview:
It would be great to figure out a good way to test this script.
Related Issue Link(s):
Release/Deployment notes: