Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TYPO3 11 Backend URL rewriting support and php7.4 default for TYPO3 #2704

Merged
merged 3 commits into from Dec 21, 2020
Merged

Add TYPO3 11 Backend URL rewriting support and php7.4 default for TYPO3 #2704

merged 3 commits into from Dec 21, 2020

Conversation

gilbertsoft
Copy link
Member

@gilbertsoft gilbertsoft commented Dec 19, 2020 •
edited

The Problem/Issue/Bug:

With the patch 67083 TYPO3 introduces URL rewriting for the Backend and therefor the Nginx configuration needs to be adapted like explained for Apache see https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/master/Breaking-93048-BackendURLRewrites.html#migration. Currently after the login to the backend this error occurs:
The page did not exist or was inaccessible. Reason: The requested page does not exist

Also minimal support for PHP was raised to 7.4 which must also be addressed.

How this PR Solves The Problem:

This change adds an additional configuration for Nginx and the default PHP version for the project type typo3 was changed to 7.4.

Manual Testing Instructions:

Without this change the backend will fail after login with this error: The page did not exist or was inaccessible. Reason: The requested page does not exist

Testing instructions:

ddev config --project-type=typo3 --docroot=public --create-docroot
ddev composer create "typo3/cms-base-distribution:dev-master"
ddev exec touch public/FIRST_INSTALL
ddev launch
  • Finish the Install Wizard
  • Login to the Backend

If no error is shown the test is successful.

This change was tested with TYPO3 11 (master), 10.4 and 9.5 and works fine so far.

Automated Testing Overview:

Related Issue Link(s):

Release/Deployment notes:

@maddy2101
Copy link
Contributor

did you leave out the apache config change on purpose?

@gilbertsoft
Copy link
Member Author

gilbertsoft commented Dec 19, 2020 •
edited

did you leave out the apache config change on purpose?

Yes, Apache is handled with the default .htaccess delivered by the install tool see https://review.typo3.org/c/Packages/TYPO3.CMS/+/67083/22/typo3/sysext/install/Resources/Private/FolderStructureTemplateFiles/root-htaccess. We do not have a special configuration in DDEV here. But thanks for the hint!

@maddy2101
Copy link
Contributor

all right, better safe than sorry :) Thank you for the effort and all the work. I have no idea what I should do these days if there were no ddev.

rfay
rfay requested changes Dec 19, 2020
View reviewed changes
Copy link
Member

@rfay rfay left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please do a 'make packr2: and commit the results.
  • Please explain more clearly how to test and verify that this does what's needed ior doesn't). Does it ail on the backend without this patch?

@gilbertsoft
Copy link
Member Author 

* Please do a 'make packr2: and commit the results.

* Please explain more clearly how to test and verify that this does what's needed ior doesn't). Does it ail on the backend without this patch?

Changed the PR description above. Will check again once my PR for the base-dist was merged...

@gilbertsoft
Copy link
Member Author

Tested again now with the latest (green) build and everything works fine and as expected.

Updated also the testing instructions.

@rfay rfay changed the title Add TYPO3 11 Backend URL rewriting support Add TYPO3 11 Backend URL rewriting support and php7.4 default for TYPO3 Dec 21, 2020
rfay
rfay approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this without the patch and got the failure logging into the backend.

I tested with the patch and it logs in fine.

I tested a ddev config from scratch, and when typo3 project type is detected or specified, it uses php7.4 by default.

Seems good to go.

I note in passing that I'm unable to log into the backend using http, and no message is given, it just keeps coming back to the login page.

@rfay rfay merged commit 9cf1f86 into ddev:master Dec 21, 2020
@liayn
Copy link
Contributor

liayn commented Dec 22, 2020

For the record: the referenced documentation has been moved to: https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/11.0/Breaking-93048-BackendURLRewrites.html#migration

joelpittet added a commit to joelpittet/ddev that referenced this pull request Dec 24, 2020
@joelpittet
Merge remote-tracking branch 'upstream/master'
78385f8 
* upstream/master:
  Replace TYPO3 Backend folder nginx redirect in favor of a rewrite (ddev#2709)
  Add TYPO3 11 Backend URL rewriting support and php7.4 default for TYPO3 (ddev#2704)
  Fix syntax errors in xdebug custom command (ddev#2694)
  Use XDEBUG_MODE to disable xdebug in Dockerfile, not disable_xdebug (ddev#2693)
  [docs] Clarify that ddev xdebug should be executed in project directory  (ddev#2692) [skip ci][ci skip]
  Bump upstream php packages to get xdebug 3.0.1 (ddev#2691), fixes ddev#2689
@gilbertsoft gilbertsoft deleted the typo3-11-support branch January 9, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnf bnf bnf left review comments

@rfay rfay rfay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gilbertsoft @maddy2101 @liayn @rfay @bnf