Bump PHP default to php7.4, fixes #2657 #2716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is failing on magento 2. And I think TestDdevFullSiteSetup is using an older version of Magento 2, probably 2.2 or something. So the test files need to be rejiggered. And it looks a little complicated. When fixing this, name those files better so we know what magento2 version is inside. |
rfay
force-pushed
the
20201229_php7.4
branch
3 times, most recently
from
97a3669
to
b728854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
Time marches on and now PHP does too. PHP7.4 is now the stable version, so we should use it by default.
How this PR Solves The Problem:
Change the default in both web container and ddev code to 7.4
This also removes the typo3ConfigOverrideAction that was added for TYPO3 v11.
Manual Testing Instructions:
ddev configa project without specifying PHP version.ddev exec php --versiondocker run -it --rm drud/ddev-webserver:20201229_php7.4 php --versionshould also give 7.4