Stop using drush launcher, use drush8 for drupal6/7, fixes #2514 #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
force-pushed
the
20201230_stop_using_drush_launcher
branch
from
9fdb7e5
to
975e141
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
#2514: drush launcher really isn't useful in the post-drupal7-world. It's better for d8/d9 people to just site-install drush and pick up vendor/bin/drush, which is already in the $PATH in the web container
How this PR Solves The Problem:
Manual Testing Instructions:
ddev drush --versionshould show only drush 8 (and not drush launcher)ddev drush --versionwill show the site-installed drush. If no site-installed drush, it will fail. It may be that the drush command should be updated here to check for the existence of drush in vendor/bin/drush