Use default_server in nginx configs instead of server_name _, fixes #2729 #2731

rfay · 2021-01-06T15:54:15Z

The Problem/Issue/Bug:

Our nginx configs were using an obsolete technique to provide a catch-all server. They should use listen....default_server

Change the provided configs to use default_server
Change in ddev-router
Simplify the base of nginx.tmpl so it doesn't need two stanzas (for http and https)

Try the problem case in secondary docroot can break main project domain due to alpha order of config files #2729. It should work OK.
Test with extra services like solr
Test with multiple sites running with have extra services, and visit the services

…_name, fixes ddev#2729

rfay requested a review from gilbertsoft January 6, 2021 15:54

rfay force-pushed the 20210106_nginx_default_server branch from 31fc9fc to 689b1f4 Compare January 9, 2021 04:33

rfay added 4 commits January 12, 2021 14:58

Use listen...default_server in nginx config instead of invalid server…

d5e4eea

…_name, fixes ddev#2729

Bump image versions

b8c3d1f

Change ddev_router to use default_server

da0479e

Add packr2 assets for nginx configs

12795cd

rfay force-pushed the 20210106_nginx_default_server branch from 689b1f4 to 12795cd Compare January 12, 2021 22:33

rfay merged commit 5427087 into ddev:master Jan 13, 2021

rfay deleted the 20210106_nginx_default_server branch January 13, 2021 02:07