Give an error on duplicate snapshot anme, fixes #2515 #2739
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
#2515 points out that if you reuse an existing snapshot name it makes a mess
How this PR Solves The Problem:
Check first
Manual Testing Instructions:
ddev snapshot --name=something && ddev snapshot --name=something
should give an intelligible errorAutomated Testing Overview:
Added this situation to the main test
Related Issue Link(s):
Release/Deployment notes: