gitpod: Move make into init in .gitpod.yml #2933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
force-pushed
the
20210407_gitpod_prebuild
branch
from
9985ed7
to
a01e910
Compare
rfay
force-pushed
the
20210407_gitpod_prebuild
branch
from
56de190
to
06d8796
Compare
|
This definitely isn't perfect yet (the add-on junk project doesn't work right in gitpod), but I think it's worth pulling because it gets the gitpod check working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
The gitpod check is likely not running because there is no init.
With the latest gitpod as of yesterday, there's no need to delay the make and ddev start
How this PR Solves The Problem:
Add an init that does basic make and setup.
See also #2935
Manual Testing Instructions:
Automated Testing Overview:
Related Issue Link(s):
Release/Deployment notes: