Add tests to check for expiring apt keys in images #2958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
force-pushed
the
20210423_check_expiring_keys
branch
from
507c16e
to
3621593
Compare
Also removes an obsolete skip for xdebug on php5.6, no longer needed
rfay
force-pushed
the
20210423_check_expiring_keys
branch
from
10290c1
to
8aff981
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
We've periodically had problems with expiring apt keys inside the container, especially the web container
How this PR Solves The Problem:
Check during build to see that keys are no closer than 90 days from expiration.
Manual Testing Instructions:
Tests only.
Automated Testing Overview:
This adds tests for each image to make sure that we're no closer than 90 days to expiration.