Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to build chocolatey on interim revisions #3012

Merged
merged 2 commits into from
May 19, 2021

Conversation

rfay
Copy link
Member

@rfay rfay commented May 19, 2021

The Problem/Issue/Bug:

The new github builds try to build chocolatey on interim revisions, and it blows sky-hi because choco can't accept something like 1.17.2-12-g7a20a436

How this PR Solves The Problem:

Don't try to build chocolatey in that situation.

Manual Testing Instructions:

Release/Deployment notes:

After this goes in we can re-add CHOCOLATEY_API_KEY to the repository

@gitpod-io
Copy link

gitpod-io bot commented May 19, 2021

@rfay rfay merged commit 266ad75 into ddev:master May 19, 2021
@rfay rfay deleted the 20210519_no_chocolatey_on_interim branch May 19, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant