Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prebuild is getting deprecated #3032

Merged
merged 1 commit into from
Jun 2, 2021
Merged

prebuild is getting deprecated #3032

merged 1 commit into from
Jun 2, 2021

Conversation

shaal
Copy link
Collaborator

@shaal shaal commented Jun 2, 2021

Details: gitpod-io/gitpod#4205

The Problem/Issue/Bug:

How this PR Solves The Problem:

Manual Testing Instructions:

Automated Testing Overview:

Related Issue Link(s):

Release/Deployment notes:

@gitpod-io
Copy link

gitpod-io bot commented Jun 2, 2021

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And prebuild didn't seem to actually do anything anyway. You still have to wait and wait for it to do it all.

@rfay rfay merged commit ecd521d into ddev:master Jun 2, 2021
@shaal
Copy link
Collaborator Author

shaal commented Jun 2, 2021

@rfay AFAIK, prebuilds do run in the background, after you push a branch or open a PR.
If you open that new workspace before the prebuild finished, you will see the prebuild process itself.
No?

@shaal shaal deleted the patch-9 branch June 2, 2021 21:32
@rfay
Copy link
Member

rfay commented Jun 2, 2021

I haven't found at any time that the prebuild/init stuff has completed before I try clicking the link in the PR, even if it's hours later.

@shaal
Copy link
Collaborator Author

shaal commented Jun 3, 2021

That sounds like a bug.

@rfay
Copy link
Member

rfay commented Jun 3, 2021

Yes, gitpod-io/gitpod#4054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants