Don't allow docker-compose v2 to be used #3086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Tested this on macOS, Windows 11, WSL2, and Ubuntu 20.04 and it seems to work correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
Currently there are so many bugs on docker-compose v2 beta that it's unusable for most ddev purposes.
This PR checks for compose v2 and refuses to use it, and gives instruction.
For a current list of incompatibilities and problems, see #3083 (comment)
How this PR Solves The Problem:
Improve the version constraint to disallow v2
Add an extra error message explaining about v2
Manual Testing Instructions:
With compose v2 enabled,
ddev start. It should fail, explaining why.Then
docker-compose disable-v2andddev start. It should work.Release/Deployment notes:
Hopefully we can revert this when compose v2 is fully functional and compatible.