New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve xhprof availability and revert to just using the classic run list page #3087
Conversation
@LionsAd @penyaskito I'd love if you could take a look at this, especially the rewritten prepend script (and append is gone). I'm adding manual testing instructions to the OP. |
… and other things
841b043
to
f00a97b
Compare
include_once '/var/www/xhprof/xhprof_lib/utils/xhprof_runs.php'; | ||
|
||
$xhprof_runs = new XHProfRuns_Default(); | ||
$run_id = $xhprof_runs->save_run($xhprof_data, $appNamespace); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we want the ability for a dev user to supply their own script here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been thinking about that, and definitely agree. Can go so very far into the weeds. I've also thought about having the script optionally add the link at the bottom. But mucking with the output breaks all APIs and all command-line scripts and lots of web pages (like TYPO3).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be cool to have the shutdown function include a file which was easily editable by the user, perhaps empty by default.
The Problem/Issue/Bug:
How this PR Solves The Problem:
Manual Testing Instructions:
brew unlink ddev
and just put the downloaded ddev in your PATH. Alternately, use gitpod by visiting link and you'll have the built item all set up.ddev xhprof on
Automated Testing Overview:
Nothing new
Related Issue Link(s):
Release/Deployment notes: