Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug download images with mutagen and docker compose #3472

Merged

Conversation

shaal
Copy link
Collaborator

@shaal shaal commented Dec 25, 2021

The Problem/Issue/Bug:

docker-compose and mutagen are images that are currently loaded upon request.

How this PR Solves The Problem:

Updating ddev debug download-images command, to include the missing images.

Manual Testing Instructions:

  1. Run ddev debug download-images and confirm it includes mutagen and docker-compose.
  2. Run ddev start, and confirm that no extra images are downloaded.

Automated Testing Overview:

Related Issue Link(s):

Release/Deployment notes:

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, those aren't docker images, so this can't work. They're binaries downloaded by DownloadMutagenIfNeeded() and DownloadDockerComposeIfNeeded()

@rfay
Copy link
Member

rfay commented Dec 25, 2021

If you'd like to work together on this to sort out how it should be done I'd love to work with you on it.

@shaal
Copy link
Collaborator Author

shaal commented Dec 26, 2021

@rfay yes please! I'd love to work together on this!

@rfay rfay force-pushed the debug-download-images-with-mutagen-and-docker-compose branch from c92d360 to e7e9b59 Compare January 8, 2022 14:21
@rfay rfay merged commit 7191e28 into ddev:master Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants