Make sure that ~/.ddev exists very early, fixes #358 #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
force-pushed
the
20170706_create_home_ddev
branch
from
4ed2c6f
to
9809ca1
Compare
beeradb
suggested changes
Jul 7, 2017
tannerjfco
approved these changes
Jul 7, 2017
rfay
force-pushed
the
20170706_create_home_ddev
branch
from
9809ca1
to
87a8dcb
Compare
|
Thanks for the coaching on how to get a test in there @beeradb - I think this will do it. |
beeradb
approved these changes
Jul 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem:
We have a couple of ways that ~/.ddev might not get created at the right time and it's absolutely essential for both mounts (mysql health) and updatecheck.
The Fix:
Create ~/.ddev in root.go at the very beginning before the updatecheck.
The Test:
rm -r ~/.ddev and then
ddev startThis should be tested explicitly on windows.
Automation Overview:
Adds TestCreateGlobalDdev as a test - it changes the $HOME environment variable in order to much with ~/.ddev without breaking the user's system.
Related Issue Link(s):
OP #358
Release/Deployment notes: