-
-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue where the script doesn't fire on page load or search. #4069
Conversation
Thanks for working on this @mikesnoeren ! Please keep working on it! If I go to https://ddev--4069.org.readthedocs.build/en/4069/users/install/docker-installation/#linux on a browser that's setting on the front page... It just lands on https://ddev--4069.org.readthedocs.build/en/4069/users/install/docker-installation, the base page, not on the tab. However, I see that if I go to https://ddev--4069.org.readthedocs.build/en/4069/users/install/ddev-installation/#windows-wsl2 it does great AND it highlights the Windows WSL2 tab. So I think it's going to work, we just have some miles to walk yet. Thanks! |
I'm sorry but I can't reproduce that, everything works fine for me. |
Works for me in incognito also. |
@mikesnoeren I see somewhat unpredictable results. Most things work, but several of those failed. I guess I should look at the console for js errors? And when I return to them they often work. So we obviously have a huge step forward, but I'd appreciate if you could try those various things. |
I just tried the first item (macOS, Chrome, incognito) a few times and it failed each time. Searched for steps, got the URL https://ddev--4069.org.readthedocs.build/en/4069/users/install/docker-installation/#linux, it landed on the macOS tab. Edit: Repeatable, nothing in browser console. Edit: Just tried the same test (not incognito) in Firefox, same result, failed. |
…he search functionality
I disabled the If the |
Thanks, I'll give it a go! |
Thanks so much, absolutely awesome! |
Thanks so much for solving this! |
The Problem/Issue/Bug:
This PR fixes part of this issue by triggering the
fixTabs
function on page load and on hash change.Manual testing
Use this link to test, you'll notice the page automatically opening the Linux tab.