Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pantheon and Colima docs - Add step to set DNS Nameserver IP address #4076

Merged
merged 8 commits into from
Aug 4, 2022
Merged

Update Pantheon and Colima docs - Add step to set DNS Nameserver IP address #4076

merged 8 commits into from
Aug 4, 2022

Conversation

tekNorah
Copy link
Contributor

@tekNorah tekNorah commented Aug 3, 2022

The Problem/Issue/Bug:

Unable to pull db from pantheon after switching to colima

How this PR Solves The Problem:

Add steps to docs regarding setting a DNS Nameserver IP address in Colima configuration

Manual Testing Instructions:

Automated Testing Overview:

No tests included, only docs have been updated.

Related Issue Link(s):

Unable to pull db from pantheon after switching to colima

Release/Deployment notes:

No anticipated deployment steps.

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can pull these as a batch if you're OK with them. Just "add to batch" and then make them one push. And if you're ambitious, add "nameserver" to the .spellcheckwordlist. If you're not, change the occurrences to "name server"

docs/content/users/install/docker-installation.md Outdated Show resolved Hide resolved
docs/content/users/install/docker-installation.md Outdated Show resolved Hide resolved
docs/content/users/install/docker-installation.md Outdated Show resolved Hide resolved
docs/content/users/install/docker-installation.md Outdated Show resolved Hide resolved
pkg/ddevapp/dotddev_assets/providers/pantheon.yaml.example Outdated Show resolved Hide resolved
tekNorah and others added 6 commits August 3, 2022 18:07
Co-authored-by: Randy Fay <randy@randyfay.com>
Co-authored-by: Randy Fay <randy@randyfay.com>
Co-authored-by: Randy Fay <randy@randyfay.com>
Co-authored-by: Randy Fay <randy@randyfay.com>
Co-authored-by: Randy Fay <randy@randyfay.com>
@rfay
Copy link
Member

rfay commented Aug 3, 2022

Your edited docs are at https://ddev--4076.org.readthedocs.build/en/4076/

@@ -31,8 +31,10 @@ If you have ddev installed, and have an active Pantheon account with an active s

8. In your **project's** .ddev/providers directory, copy pantheon.yaml.example to pantheon.yaml (_Note that this refers to your project .ddev folder and not the global .ddev folder_). Edit the `project` environment variable under `environment_variables`. It will be in the format `<projectname>.<environment>`, for example `yourprojectname.dev` or (in cases of ambiguity) `<project_uuid>.<environment>`, for example `009a2cda-2c22-4eee-8f9d-96f017321555.dev`.

9. `ddev restart`
9. If using Colima, may need to set an explicit nameserver in `~/.colima/default/colima.yaml` like `1.1.1.1`. If this configuration is changed, may also need to [restart colima](https://ddev.readthedocs.io/en/stable/users/install/docker-installation/).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfay - I notice the "restart Colima" link does not actually link directly to the macOS: Colima tab. See: https://ddev--4076.org.readthedocs.build/en/4076/users/providers/pantheon/

Any suggestions here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be a relative link in the docs, not a link to ddev.readthedocs.io, thanks for catching that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OTOH, I'm not sure a link is needed at all. But if a link, it should be a relative link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I'll just remove the link

@rfay rfay merged commit 1f3bd1f into ddev:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants