Mutagen rework to use volume label and session label #4109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
rfay
force-pushed
the
20220811_mutagen_container_name
branch
from
974e7d5
to
3f20619
Compare
rfay
changed the title
1 task
rfay
changed the title
rfay
force-pushed
the
20220811_mutagen_container_name
branch
4 times, most recently
from
c3bd56e
to
085ba0f
Compare
rfay
force-pushed
the
20220811_mutagen_container_name
branch
5 times, most recently
from
766ca50
to
afc0e7c
Compare
rfay
force-pushed
the
20220811_mutagen_container_name
branch
from
769f8a1
to
8926c93
Compare
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
@xenoscopic, maintainer of mutagen, suggests that we can have a more successful mutagen lifecycle by using the container name for beta identifier instead of using the container id. This is a first test of that. I originally did it that way, but switched to ID for some reason.
When the container name is used, we can pause the mutagen session instead of terminating it, and it will do better with a number of things. That's not here yet, but if things work out in automated tests it has potential.
How this PR Solves The Problem:
mutagencommands, especiallymutagen sync listTODO
mutagen sync listfilter so we don't have to get all sessionsddev poweroffstop all mutagen sessions? Probably.ddev poweroffmeans that mutagen will have to be re-synced because mutagen session is killed off.ddev stopdoesn't do that.ddev cleanshould clear MUTAGEN_DATA_DIRECTORY.Manual Testing Instructions:
ddev restart. Does it reappear?Automated Testing Overview:
Related Issue Link(s):
Release/Deployment notes:
MUTAGEN_DATA_DIRECTORY=~/.ddev_mutagen_data_directory