Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve apt packages and docs, fixes #4112, fixes #4113, fixes #4125 #4133

Merged
merged 7 commits into from
Aug 22, 2022

Conversation

rfay
Copy link
Member

@rfay rfay commented Aug 19, 2022

@rfay rfay changed the title Improve apt packages and docs, fixes #4112, fixes #4113 Improve apt packages and docs, fixes #4112, fixes #4113, fixes #4125 Aug 19, 2022
@rfay rfay changed the title Improve apt packages and docs, fixes #4112, fixes #4113, fixes #4125 Improve apt packages and docs, fixes #4112, fixes #4113, for #4125 Aug 20, 2022
@rfay rfay changed the title Improve apt packages and docs, fixes #4112, fixes #4113, for #4125 Improve apt packages and docs, fixes #4112, fixes #4113, fixes #4125 Aug 22, 2022
@rfay rfay marked this pull request as ready for review August 22, 2022 02:56
@rfay
Copy link
Member Author

rfay commented Aug 22, 2022

@bserem I'd love it if you can review this and also test out the package. You can get it by temporarily

  1. sudo apt remove ddev
  2. Put deb [trusted=yes] https://apt.fury.io/rfay-test-org/ / in your /etc/apt/sources.list.d/ddev.list

This will get a test version pushed up from my fork, v1.20.1-alpha2. You can uninstall and go back to regular settings afterward.

@bserem
Copy link
Collaborator

bserem commented Aug 22, 2022

@rfay thanks for working on this.

I can verify that it works on my machine. So, that's one off the list!

Update: removing and installing the previous version also removed bash completion, so uninstallation also works properly

@rfay
Copy link
Member Author

rfay commented Aug 22, 2022

Thanks for testing and for checking this through so carefully. Not sure why I thought it would work as is. Probably because homebrew takes care of those things a bit magically.

@rfay rfay merged commit e7ba6a4 into ddev:master Aug 22, 2022
@rfay rfay deleted the 20220819_improve_apt branch August 22, 2022 16:02
@bserem
Copy link
Collaborator

bserem commented Aug 22, 2022

Anytime!

Apt is a new territory for ddev, things will be ironed out eventually. Personally I'm grateful for the new repo, it makes more sense for Linux systems.

See ya on the next issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants