-
-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump mutagen (v0.16.0-beta1) for non-utf8 filenames and set it to use windows 777 permissions #4206
Conversation
Download the artifacts for this pull request: |
@ursbraem please take a look at this when you get a chance, would love it if you could test the binary against your problem site. |
Sure! Can you instruct me on how to install? I am back on regular homebrew ddev, how do I use the version to test with? |
Hi @ursbraem - For this PR you would get the proper zipball from #4206 (comment) and then you can install ddev where you want it in your $PATH. You can either put somewhere before where it shows up in brew or you can |
8a7f4a4
to
828950d
Compare
Ok, just for the record (if I have to do it again): I did In Now I'm doing my rsync again to get all files freshened up from the production site. |
Don't forget you'll have to either put your non-utf8 files in the main directory or temporarily remove the upload_dir or whatever changes you made to mutagen.yml |
This improves handling of non-utf8 filenames And can improve Windows permissions
This work had already been done. This reverts commit 74c2f72.
828950d
to
6b9c6df
Compare
With this version, mutagen did not croak anymore. But
Actually, these are the filenames:
So it's the standalone diacritic characters. But not generally, I could even call a new file (By the way, So here is a ZIP with the original files: I went to the containing directories in TYPO3 on production, but the directories couldn't be listed in the File module due to those bad characters. I renamed the files on the servers file system (in the database, their identifier was already listed with the actual umlauts) and all issues were gone. Also, after rsyncing the entire filadmin to ddev, mutagen reported no more errors. Problem solved, I'd dare to say... |
Thanks so much for reporting this and pursuing it to the end! And thanks to @xenoscopic for the great fix to mutagen. |
The problematic Most applications/OSes nowadays (at least within the last decade, maybe longer) will write the filenames using a Unicode-based encoding (usually UTF-8 or UTF-16 [1]), but there will be that occasional "vintage" filename (especially on Linux) that's encoded with some other encoding that mostly overlaps with ASCII and UTF-8 for Latin (and extended Latin) characters, but not quite. And, of course, these other encodings can still be used for Linux systems' locales (though it's not a common choice). [1] And on systems that do use UTF-16, the file is typically converted to UTF-8 by either the OS or most libraries/runtimes when returned from a |
Sure! Can you instruct me on how to install? I am back on regular homebrew
ddev, how do I use the version to test with?
|
Hi @ursbraem there will be a new release v1.21.2 with this in it today, but to get current HEAD with ddev, |
The Problem/Issue/Bug:
TODO
ddev debug mutagen ...
work with flags; we can use that to terminate mutagen sessionsHow this PR Solves The Problem:
Manual Testing Instructions:
Automated Testing Overview:
Related Issue Link(s):
Release/Deployment notes: