Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Symfony Mailer config for Mailhog in Drupal 9 settings #2706 #4214

Merged
merged 5 commits into from
Oct 8, 2022

Conversation

luenemam
Copy link
Contributor

@luenemam luenemam commented Sep 19, 2022

The Problem/Issue/Bug:

How this PR Solves The Problem:

Manual Testing Instructions:

mkdir my-drupal9-site
cd my-drupal9-site
ddev config --project-type=drupal9 --docroot=web --create-docroot
ddev start
ddev composer create "drupal/recommended-project" --no-install
ddev composer require drush/drush --no-install
ddev composer require drupal/symfony_mailer --no-install
ddev composer install
ddev drush site:install -y
ddev drush pm:install symfony_mailer
ddev drush user:login "admin/config/system/mailer/test"

Use the login link to go to the page send a test mail.
Verify mailhog recieves the test mail.

Automated Testing Overview:

Related Issue Link(s):

#2706

Release/Deployment notes:

@github-actions
Copy link

@rfay
Copy link
Member

rfay commented Sep 25, 2022

Let me know when you've manually tested and like it, and set it to be ready for review. Thanks for this!

@rfay
Copy link
Member

rfay commented Sep 26, 2022

A minor update to the docs could be added to this, with a link to symfony mailer

@rfay
Copy link
Member

rfay commented Oct 4, 2022

This might make it into next point release if it happens this week :)

@rfay rfay force-pushed the symfony_mailer_config_for_mailhog branch from 6d255bf to 7126527 Compare October 5, 2022 17:56
@rfay
Copy link
Member

rfay commented Oct 5, 2022

Rebased to pick up docs changes and a number of other things. Make sure you update your local appropriately.

@luenemam
Copy link
Contributor Author

luenemam commented Oct 7, 2022

I've tested on GitPod. It's working as expected.

@luenemam luenemam marked this pull request as ready for review October 7, 2022 08:28
@luenemam luenemam force-pushed the symfony_mailer_config_for_mailhog branch from c6aef81 to 2e5b7f1 Compare October 7, 2022 09:08
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice that this hadn't been done for drupal10, could you please add it there? https://github.com/drud/ddev/blob/master/pkg/ddevapp/drupal/drupal10/settings.ddev.php

docs/content/users/basics/developer-tools.md Outdated Show resolved Hide resolved
@rfay
Copy link
Member

rfay commented Oct 7, 2022

Thanks, I think adding the drupal10 config pre-emptively causes no harm and leaves out a whole future maintenance step.

@rfay
Copy link
Member

rfay commented Oct 7, 2022

Testing. Can't believe symfony mailer is alpha.

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me with local testing, thanks so much!

@luenemam
Copy link
Contributor Author

luenemam commented Oct 7, 2022

Yes, they are ambitious to design a new mail system for drupal.

@rfay rfay force-pushed the symfony_mailer_config_for_mailhog branch from 4fcaf92 to 167a188 Compare October 7, 2022 16:58
@rfay rfay merged commit 9308eff into ddev:master Oct 8, 2022
@luenemam luenemam deleted the symfony_mailer_config_for_mailhog branch October 8, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants