-
-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Symfony Mailer config for Mailhog in Drupal 9 settings #2706 #4214
Conversation
Download the artifacts for this pull request: |
Let me know when you've manually tested and like it, and set it to be ready for review. Thanks for this! |
A minor update to the docs could be added to this, with a link to symfony mailer |
This might make it into next point release if it happens this week :) |
6d255bf
to
7126527
Compare
Rebased to pick up docs changes and a number of other things. Make sure you update your local appropriately. |
I've tested on GitPod. It's working as expected. |
c6aef81
to
2e5b7f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't notice that this hadn't been done for drupal10, could you please add it there? https://github.com/drud/ddev/blob/master/pkg/ddevapp/drupal/drupal10/settings.ddev.php
Thanks, I think adding the drupal10 config pre-emptively causes no harm and leaves out a whole future maintenance step. |
Testing. Can't believe symfony mailer is alpha. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me with local testing, thanks so much!
Yes, they are ambitious to design a new mail system for drupal. |
Co-authored-by: Randy Fay <randy@randyfay.com>
4fcaf92
to
167a188
Compare
The Problem/Issue/Bug:
How this PR Solves The Problem:
Manual Testing Instructions:
Use the login link to go to the page send a test mail.
Verify mailhog recieves the test mail.
Automated Testing Overview:
Related Issue Link(s):
#2706
Release/Deployment notes: