Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't stop project on start failure #4235

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Don't stop project on start failure #4235

merged 1 commit into from
Sep 30, 2022

Conversation

rfay
Copy link
Member

@rfay rfay commented Sep 28, 2022 •
edited

The Problem/Issue/Bug:

I noted on some types of start failure, the project was being stopped, which means you can't then examine any of the logs, etc.

This change was made recently in

How this PR Solves The Problem:

Instead of stopping the project in this situation, let it be, and just make sure the mutagen session is stopped, which I think must have been the intent in #4156

Manual Testing Instructions:

  • ddev config --fail-on-hook-fail
  • Add a hook that fails. I used
hooks:
  post-start:
    - exec: ls kdkdd
  • ddev start - Everything should start, but web fails. ddev logs should still work.

Automated Testing Overview:

Related Issue Link(s):

Release/Deployment notes:

@github-actions
Copy link

Download the artifacts for this pull request:

@rfay rfay merged commit 8971e91 into ddev:master Sep 30, 2022
@rfay rfay deleted the 20220928_dont_stop_project_on_start_failure branch September 30, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rfay