Fix postgres:9 detection of existing project, fixes #4229 #4241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
|
I'd appreciate if you could test this (anybody) but especially @njt1982. Artifacts are in #4241 (comment) More detail about how to test is in https://ddev.readthedocs.io/en/latest/developers/building-contributing/#testing-a-pr |
1 task
|
@rfay - the code change eyeballs ok... I'll try to test it later today. |
|
This can now be tested with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
How this PR Solves The Problem:
Properly handle existing postgres "9.x" as
postgres:9Manual Testing Instructions:
ddev startand empty postgres:9 and thenddev restartAutomated Testing Overview:
Added the 9.6 expectation to tests.
Related Issue Link(s):
Release/Deployment notes: