[docs] Improve ordering of Colima installation #4255
Conversation
|
I'm baffled why you closed this, then redid it, and redid it without the change I added. |
|
I closed it by mistaken. Can you send it again? |
|
When you closed it by accident, Github offered you the option of reopening it. It probably still does. Don't worry about it. But try not to do that again. We'll use this one as a reminder. |
|
I am very sorry. I'm new to pull requests from other repositories. Unfortunately I don't have your changes anymore... for this reason I could not add them anymore. |
|
I hope I have now made the correct corrections! Thanks for your tolerance. |
rfay
changed the title
|
I rebased this. Please review it again @filimoreira Here's the built version https://ddev--4255.org.readthedocs.build/en/4255/users/install/docker-installation/#colima |
| @@ -16,16 +16,46 @@ You’ll need a Docker provider on your system before you can [install DDEV](dde | |||
| Yes! See *Why do you recommend Colima over Docker Desktop on macOS?* in [the FAQ](../basics/faq.md). | |||
|
|
|||
| 1. Run `docker help` to make sure you’ve got the Docker client installed. If you get an error, install it with [Homebrew]() by running `brew install docker`. | |||
There was a problem hiding this comment.
Add missing link:
| 1. Run `docker help` to make sure you’ve got the Docker client installed. If you get an error, install it with [Homebrew]() by running `brew install docker`. | |
| 1. Run `docker help` to make sure you’ve got the Docker client installed. If you get an error, install it with [Homebrew](https://brew.sh) by running `brew install docker`. |
|
|
||
| After the initial run in step 4 above, you can just use `colima start` or use `colima start -e` to edit the configuration file. Run `colima status` at any time to check Colima’s status. | ||
| After the initial run above, you can just use `colima start` or use `colima start -e` to edit the configuration file. Run `colima status` at any time to check Colima’s status. |
There was a problem hiding this comment.
Get rid of “just”. (I must have missed this earlier!)
| After the initial run above, you can just use `colima start` or use `colima start -e` to edit the configuration file. Run `colima status` at any time to check Colima’s status. | |
| After the initial run above, you can use `colima start` or use `colima start -e` to edit the configuration file. Run `colima status` at any time to check Colima’s status. |
|
|
||
| Reasons to use Colima include: |
There was a problem hiding this comment.
Somehow lines 28–42 and 44–58 got re-added twice. Could you please delete each of those chunks?
You can use this page for reference; should see...
- Steps 1-4
- “After the initial run (...)”
- “When your computer restarts, (...)”
- Tip: “Colima disk allocation”
- Warning: “Docker contexts let (...)”
|
I gave up on the rebase and just applied the changes again :( Please take a look again both of you. :( |
|
Looks good to me, @rfay! |
|
Thanks for fixing this @filimoreira ! |
The Problem/Issue/Bug:
If I first run ´ddev config global --mutagen-enabled´ I get this error message:
Could not connect to a docker provider. Please start or install a docker provider. For install help go to: https://ddev.readthedocs.io/en/latest/users/install/
How this PR Solves The Problem:
Change the order (switch 2. ´ddev config global --mutagen-enabled´ & 3. colima start --cpu 4 --memory 6 --disk 100 --dns=1.1.1.1)
Manual Testing Instructions:
Automated Testing Overview:
it's a cmd command
Related Issue Link(s):
https://ddev.readthedocs.io/en/latest/users/install/docker-installation/
Release/Deployment notes:
no