-
-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update example service list #4263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. That's the actual output now right?
@rfay Actual output right now does not include the cheats I mentioned above:
(Lowercase “memcached” and MongoDB “addon”.) |
Can we actually just fix the repos in question? It's just a moment. |
Is that it? |
Those are the repository descriptions, right? I assume only you can edit them, but if I can I’d be happy to do it. I have more notes on those descriptions but haven’t filed them in an issue yet. Example:
This might as well be shortened so it matches its peers:
|
This is the opposite of the direction I’ve been going—where “add-on” is the winner. It’s used more frequently in the docs and in repository descriptions. |
Reverted Elasticsearch and changed Mongo to add-on |
@rfay Was diffing this PR against my CLI output; what determines the order these come back in? Is it possible to alphabetize by repository name or is there an order I’m failing to pick up on? |
I think it's just the github api with no intervention right now. Could probably be sorted, most likely after we get it. |
Use `→ ` for user action, include entire current output.
Just updated this to include all the items I see in my current CLI output, and to again use that |
OK, let me know when you're happy. |
@rfay Officially happy! |
The Problem/Issue/Bug:
After #4200 and subsequent updates to some GitHub repository descriptions, the
ddev get --list
example is stale.How this PR Solves The Problem:
This fixes that situation, in a refreshingly small PR. Also cheats by fixing an “addon” that should be “add-on”, and capitalizing Memcached which, against all odds, appears to be a proper noun for the product.
Manual Testing Instructions:
https://ddev.readthedocs.io/en/stable/developers/testing-docs/#preview-your-changes
Automated Testing Overview:
Only Markdown; no new tests needed.
Release/Deployment notes:
n/a