Add support for TYPO3 v12 #4268
Conversation
|
Download the artifacts for this pull request: |
docs/content/users/quickstart.md
Outdated
| ddev start | ||
| ddev composer create "typo3/cms-base-distribution" --no-install | ||
| ddev composer install | ||
| ddev config --auto |
There was a problem hiding this comment.
Instead of ddev config --auto we also could recommend ddev restart to create the settings file. AFAIK this is a long standing issue anyway since the introduction of the --no-install option.
There was a problem hiding this comment.
Why would we do a ddev config --auto when we just did the explicit ddev config above? It doesn't seem like this belongs at all.
There was a problem hiding this comment.
Because the settings file isn't created without.
There was a problem hiding this comment.
Other solution would be to create the files even with a simple ddev composer command.
There was a problem hiding this comment.
I've checked the sources again, at the moment the settings files are create with start, config and importdb. Because I now need TYPO3 properly to be installed for the detection of the version, the behavior has changed a bit and doesn't currently work without an additional line her.
There was a problem hiding this comment.
Settings file is created on ddev start if the project type is set.
There was a problem hiding this comment.
Hope this should be clear now after your discussion yesterday and finally it's solved with #4273.
There was a problem hiding this comment.
No, I never did understand, but glad about #4273.
There was a problem hiding this comment.
Oh, I see now. A ddev restart after the ddev composer install would have worked and is probably better, especially wrt mutagen. But we can go with this as it is now.
There was a problem hiding this comment.
Yes, I have already mentioned we can use both. So if you're happier with a restart, lets do a restart :)
| @@ -62,7 +69,7 @@ func writeTypo3SettingsFile(app *DdevApp) error { | |||
| } | |||
|
|
|||
| // The directory doesn't exist, create it with the appropriate permissions. | |||
| if err := os.Mkdir(dir, perms); err != nil { | |||
| if err := os.MkdirAll(dir, perms); err != nil { | |||
There was a problem hiding this comment.
This also fixes a long standing issue with older versions.
|
This one I'd dearly love to get into v1.21.2, which I hope to cut very soon, would have considered it today if this didn't come up. Thanks for the great work on this! |
gilbertsoft
force-pushed
the
task/typo3-v12-support
branch
from
449d4c2
to
c855d24
Compare
|
Fixed the failing test today and all green again :) |
|
Congrats on tests, and thanks! |
Co-authored-by: Randy Fay <randy@randyfay.com>
Co-authored-by: Randy Fay <randy@randyfay.com>
The Problem/Issue/Bug:
The new TYPO3 v12 major version has some breaking changes regarding the settings files.
How this PR Solves The Problem:
This patch introduces an automatic detection of the TYPO3 version 12 or higher and properly adapts the setting file paths and names.
To avoid the creation of the .gitignore in the wrong location, it is not written anymore before TYPO3 is installed or the version could be properly detected.
Manual Testing Instructions:
Follow the quick start guide to test this change. To test it for a previous version just add a version to the composer create command e.g.:
Automated Testing Overview:
Related Issue Link(s):
TYPO3/get.typo3.org#386
Release/Deployment notes: