Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom nginx configuration links #4308

Merged
merged 2 commits into from Oct 20, 2022
Merged

Fix custom nginx configuration links #4308

merged 2 commits into from Oct 20, 2022

Conversation

bencroker
Copy link
Collaborator

@bencroker bencroker commented Oct 18, 2022 •
edited by gitpod-io bot

Fixes broken documentation links in nginx configuration files.

@bencroker bencroker changed the title Fix custom nginx configuration Fix custom nginx configuration links Oct 18, 2022
rfay
rfay approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rfay
Copy link
Member

rfay commented Oct 18, 2022

You based this on an old, old version, please rebase against upstream/master.

@bencroker
Copy link
Collaborator Author

Apologies, rebased.

@github-actions
Copy link

Download the artifacts for this pull request:

@rfay
Copy link
Member

rfay commented Oct 18, 2022

Much more success with tests, thanks! Yours was from before when Github broke every single usage of homebrew, without notice, etc.

@rfay rfay merged commit 8b714e1 into ddev:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfay rfay rfay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bencroker @rfay