New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve Craft CMS Quickstart - how to add environment variables #4314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you for the correction!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this clarification! Just needs one space.
Co-authored-by: Matt Stein <m@ttste.in>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realized we’re waiting on me to review that space. Apologies, and thanks again!
The Problem/Issue/Bug:
The original documentation related to changing where the
craft
executable is located in CraftCMS projects was slightly misleading as it implied you could make this change via an.env
file.How this PR Solves The Problem:
This PR updates the docs to show how to provide this variable via DDEV's documented methods for providing environment variables to containers.
Manual Testing Instructions:
Set up a CraftCMS project where the Craft application lives in a subdirectory. Follow the docs to set the location of the
craft
executable. Restart your project and test thatddev craft
works.Related Issue Link(s):
#4309