Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TYPO3 project detection to work with non existent symlinks, fixes #4326 #4330

Merged
merged 1 commit into from Oct 26, 2022

Conversation

gilbertsoft
Copy link
Member

@gilbertsoft gilbertsoft commented Oct 25, 2022

The Problem/Issue/Bug:

If the typo3 folder is a symlink to a non existing target the detection fails currently.

How this PR Solves The Problem:

If the first check fails, an additional check for an existing symlink is introduced.

Manual Testing Instructions:

  • Set up a TYPO3 according the legacy installation
  • Rename the source folder extracted from the package
  • Remove AddintionalConfiguration.php

The AddintionalConfiguration.php is not longer created during ddev start or ddev restart.

Automated Testing Overview:

Related Issue Link(s):

#4326

Release/Deployment notes:

@github-actions
Copy link

github-actions bot commented Oct 25, 2022

@liayn
Copy link
Contributor

liayn commented Oct 25, 2022

Works perfectly!!

@gilbertsoft gilbertsoft marked this pull request as ready for review October 25, 2022 18:09
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this manually and it's good and correct.

I'm not entirely sure that we should be writing code for broken symlinks.

Thanks so much!

@rfay rfay merged commit 2408753 into ddev:master Oct 26, 2022
@rfay rfay deleted the bugfix/typo3-project-detection branch October 26, 2022 00:30
@liayn
Copy link
Contributor

liayn commented Oct 27, 2022

I'm not entirely sure that we should be writing code for broken symlinks.

As I talked to @gilbertsoft in the TYPO3 Slack: This is actually only necessary, as we currently use the isTYPO3App function (aka "guess if it's a TYPO3", for generating the configuration.
It would be better in this case to trust what has been provided by the user in ddev config.yaml.
But I don't know the details in the ddev well enough to decide, whether this is doable at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants