New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitignore .DS_Store
and similar files
#4337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing wrong with that, but I gitignore stuff like that in global gitignore, I recommend to you as well.
My global .gitignore:
.project
.buildpath
.settings
nbproject/
.idea
.DS_Store
db/db_*
docroot/core/phpunit.xml
docroot/drush
docroot/sites/simpletest
docroot/modules/contrib/devel
sites/default/files
*.orig
*.rej
.tarballs
Oh, that makes more sense! Thank you. |
Yes, a global However, I think for a project like DDEV that recieves lots of contributions, it's helpful to have a project level one too. |
May want to add a couple more of those if we're doing this one. |
I mean now that we鈥檝e trained me to use a global file, I won鈥檛 be noticing whatever those other things are! 馃槄 馃殌 |
Another pro tip: Always use |
Co-authored-by: Randy Fay <randy@randyfay.com>
The Problem/Issue/Bug:
One might easily and accidentally commit those annoying macOS
.DS_Store
files to their commit, adding cruft to the project.How this PR Solves The Problem:
This uses the
.gitignore
file to prevent those from being noticed or committed by Git.Manual Testing Instructions:
馃 Stage this change, then purposefully try to commit a file named
.DS_Store
. It鈥檒l be trickier, at least.Automated Testing Overview:
n/a
Related Issue Link(s):
Faintly related to #4188; came up during #4336.
Release/Deployment notes:
n/a