Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fixing indentation in multiple exposed ports example YAML. #4412

Merged
merged 1 commit into from Nov 29, 2022

Conversation

quicksketch
Copy link
Contributor

@quicksketch quicksketch commented Nov 29, 2022

The Problem/Issue/Bug:

The code sample at https://ddev.readthedocs.io/en/latest/users/extend/custom-compose-files/#docker-composeyaml-examples has an indentation problem in the labels section.

image

How this PR Solves The Problem:

Reformats the whole section to use 2-spaces like the other examples on this page.

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @quicksketch !

@rfay rfay changed the title Fixing indentation in multiple exposed ports example YAML. [docs] Fixing indentation in multiple exposed ports example YAML. Nov 29, 2022
@rfay
Copy link
Member

rfay commented Nov 29, 2022

Interestingly enough, that can be an array as well, in which case it could either have or not have indentation. But we've always used the object syntax.

@rfay rfay merged commit 9049cea into ddev:master Nov 29, 2022
@quicksketch quicksketch deleted the patch-1 branch November 29, 2022 20:06
@quicksketch
Copy link
Contributor Author

Thanks @rfay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants