Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddev self-upgrade command, fixes #2680 #4419

Merged
merged 6 commits into from Dec 3, 2022
Merged

Conversation

rfay
Copy link
Member

@rfay rfay commented Nov 30, 2022

The Problem/Issue/Bug:

DDEV users sometimes don't know how to upgrade

How this PR Solves The Problem:

Add ddev self-upgrade command to give clues

Manual Testing Instructions:

Test it on

  • macOS homebrew
  • macOS install_ddev.sh
  • Linux/WSL2 homebrew
  • Linux/WSL2 install_ddev.sh
  • Linux/WSL2 apt
  • CentOS dnf
  • Arch
  • Windows (git-bash)
  • Windows (PowerShell)

Automated Testing Overview:

Related Issue Link(s):

Release/Deployment notes:

@github-actions
Copy link

github-actions bot commented Nov 30, 2022

@rfay rfay requested a review from mattstein December 2, 2022 17:31
@rfay
Copy link
Member Author

rfay commented Dec 2, 2022

@chrisfromredfin I'd love it if you could try this out. Artifacts are in #4419 (comment)

Copy link
Sponsor Collaborator

@mattstein mattstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested minor edits!

docs/content/users/basics/commands.md Outdated Show resolved Hide resolved
docs/content/users/basics/commands.md Outdated Show resolved Hide resolved
docs/content/users/basics/faq.md Outdated Show resolved Hide resolved
docs/content/users/basics/faq.md Outdated Show resolved Hide resolved
docs/content/users/basics/faq.md Outdated Show resolved Hide resolved
docs/content/users/basics/faq.md Outdated Show resolved Hide resolved
docs/content/users/basics/faq.md Show resolved Hide resolved
Co-authored-by: Matt Stein <m@ttste.in>
@rfay
Copy link
Member Author

rfay commented Dec 2, 2022

Thanks so much @mattstein - BTW you can select several lines and do a suggestion based on them, you don't have to do one line at a time.

@mattstein
Copy link
Sponsor Collaborator

BTW you can select several lines and do a suggestion based on them, you don't have to do one line at a time.

Oh big 🤦‍♂️. Thank you!

@rfay rfay merged commit 6d58572 into ddev:master Dec 3, 2022
@rfay rfay deleted the 20221130_self_upgrade branch December 3, 2022 23:28
@chrisfromredfin
Copy link
Collaborator

Just confirming here that I tested this on HEAD in two ways on macOS arm64, and got expected results for both (installed with homebrew, and installed in a random folder on my own).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants