Support GitHub Codespaces, fixes #3914 #4476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
1 task
rfay
force-pushed
the
20221220_codespaces
branch
from
1dfddbb
to
462e5b7
Compare
mattstein
requested changes
Dec 23, 2022
rfay
force-pushed
the
20221220_codespaces
branch
from
1231a79
to
4974aad
Compare
This reverts commit 579e5bf.
Co-authored-by: Matt Stein <m@ttste.in>
Co-authored-by: Matt Stein <m@ttste.in>
rfay
force-pushed
the
20221220_codespaces
branch
from
4974aad
to
99cad60
Compare
mattstein
requested changes
Dec 23, 2022
Co-authored-by: Matt Stein <m@ttste.in>
mattstein
reviewed
Dec 23, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
How this PR Solves The Problem:
Implement mostly like Gitpod
Manual Testing Instructions:
xdebug even works!
Automated Testing Overview:
At this point, it will be community support, as I don't know how to do automated tests using Github Codespaces (or Gitpod)